From 0261a3d27931e3cd20f55be547dc52f68909eb46 Mon Sep 17 00:00:00 2001
From: Aaron Stannard <aaron@petabridge.com>
Date: Sat, 18 May 2019 16:05:31 -0500
Subject: [PATCH] added Azure Pipelines build system (#3794)

---
 build-system/pr-validation.yaml   | 16 ++++++++--------
 build-system/windows-release.yaml |  2 +-
 build.fsx                         |  5 ++---
 3 files changed, 11 insertions(+), 12 deletions(-)

diff --git a/build-system/pr-validation.yaml b/build-system/pr-validation.yaml
index 7509a424c3c..26374fbe2b7 100644
--- a/build-system/pr-validation.yaml
+++ b/build-system/pr-validation.yaml
@@ -29,7 +29,7 @@ jobs:
         displayName: Windows Build
         inputs:
           filename: build.cmd
-          arguments: 'buildRelease ' # Run an  build
+          arguments: 'buildRelease incremental' # Run an incremental build
         continueOnError: true
         condition: eq( variables['Agent.OS'], 'Windows_NT' )
       - task: CopyFiles@2
@@ -42,7 +42,7 @@ jobs:
       - task: PublishBuildArtifacts@1
         inputs:
           pathtoPublish: $(Build.ArtifactStagingDirectory)
-          artifactName: istOutput
+          artifactName: incrementalistOutput
       - script: 'echo 1>&2'
         failOnStderr: true
         displayName: 'If above is partially succeeded, then fail'
@@ -54,7 +54,7 @@ jobs:
       displayName: '.NET Framework Unit Tests (Windows)'
       vmImage: 'vs2017-win2016'
       scriptFileName: build.cmd
-      scriptArgs: runTests 
+      scriptArgs: runTests incremental
       outputDirectory: 'TestResults'
 
   - template: azure-pipeline.template.yaml
@@ -63,7 +63,7 @@ jobs:
       displayName: '.NET Core Unit Tests (Windows)'
       vmImage: 'vs2017-win2016'
       scriptFileName: build.cmd
-      scriptArgs: runTestsNetCore 
+      scriptArgs: runTestsNetCore incremental
       outputDirectory: 'TestResults'
 
   - template: azure-pipeline.template.yaml
@@ -72,7 +72,7 @@ jobs:
       displayName: '.NET Core Unit Tests (Linux)'
       vmImage: 'ubuntu-16.04'
       scriptFileName: './build.sh'
-      scriptArgs: runTestsNetCore 
+      scriptArgs: runTestsNetCore incremental
       outputDirectory: 'TestResults'
 
   - template: azure-pipeline.template.yaml
@@ -81,7 +81,7 @@ jobs:
       displayName: '.NET Core Multi-Node Tests (Windows)'
       vmImage: 'vs2017-win2016'
       scriptFileName: 'build.cmd'
-      scriptArgs: MultiNodeTestsNetCore 
+      scriptArgs: MultiNodeTestsNetCore incremental
       outputDirectory: 'TestResults'
 
   - template: azure-pipeline.template.yaml
@@ -90,7 +90,7 @@ jobs:
       displayName: '.NET Framework Multi-Node Tests (Windows)'
       vmImage: 'vs2017-win2016'
       scriptFileName: 'build.cmd'
-      scriptArgs: MultiNodeTests 
+      scriptArgs: MultiNodeTests incremental
       outputDirectory: 'TestResults'
 
   - template: azure-pipeline.template.yaml
@@ -99,5 +99,5 @@ jobs:
       displayName: 'NuGet Pack'
       vmImage: 'vs2017-win2016'
       scriptFileName: build.cmd
-      scriptArgs: CreateNuget nugetprerelease=dev 
+      scriptArgs: CreateNuget nugetprerelease=dev incremental
       outputDirectory: 'bin/nuget'
diff --git a/build-system/windows-release.yaml b/build-system/windows-release.yaml
index 27fef304359..14513fcfde2 100644
--- a/build-system/windows-release.yaml
+++ b/build-system/windows-release.yaml
@@ -27,7 +27,7 @@ steps:
   displayName: 'FAKE Build'
   inputs:
     filename: build.cmd
-    arguments: 'All SignClientUser=$(signingUsername) SignClientSecret=$(signingPassword) nugetpublishurl=https://www.nuget.org/api/v2/package nugetkey=$(nugetKey)'
+    arguments: 'Nuget SignClientUser=$(signingUsername) SignClientSecret=$(signingPassword) nugetpublishurl=https://www.nuget.org/api/v2/package nugetkey=$(nugetKey)'
 
 - task: GitHubRelease@0
   displayName: 'GitHub release (create)'
diff --git a/build.fsx b/build.fsx
index 493b871ec72..c758144e0bf 100644
--- a/build.fsx
+++ b/build.fsx
@@ -93,7 +93,6 @@ let getAffectedProjects =
 
 Target "ComputeIncrementalChanges" (fun _ ->
     if runIncrementally then
-        log (sprintf "(Debug) .NET Core Root found at %s" (Environment.GetEnvironmentVariable "DOTNET_ROOT"))
         let targetBranch = match getBuildParam "targetBranch" with
                             | "" -> "dev"
                             | null -> "dev"
@@ -238,7 +237,7 @@ Target "RunTests" (fun _ ->
             info.WorkingDirectory <- (Directory.GetParent project).FullName
             info.Arguments <- arguments) (TimeSpan.FromMinutes 30.0) 
         
-        ResultHandling.failBuildIfXUnitReportedError TestRunnerErrorLevel.DontFailBuild result
+        ResultHandling.failBuildIfXUnitReportedError TestRunnerErrorLevel.Error result
 
     CreateDir outputTests
     projects |> Seq.iter (runSingleProject)
@@ -263,7 +262,7 @@ Target "RunTestsNetCore" (fun _ ->
                 info.WorkingDirectory <- (Directory.GetParent project).FullName
                 info.Arguments <- arguments) (TimeSpan.FromMinutes 30.0) 
         
-            ResultHandling.failBuildIfXUnitReportedError TestRunnerErrorLevel.DontFailBuild result
+            ResultHandling.failBuildIfXUnitReportedError TestRunnerErrorLevel.Error result
 
         CreateDir outputTests
         projects |> Seq.iter (runSingleProject)