Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cryptography to version 42.0.0 or later #34299

Closed
mansi1597 opened this issue Feb 13, 2024 · 4 comments
Closed

Upgrade cryptography to version 42.0.0 or later #34299

mansi1597 opened this issue Feb 13, 2024 · 4 comments
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-author-feedback Workflow: More information is needed from author to address the issue. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@mansi1597
Copy link

Is your feature request related to a problem? Please describe.
Upgrade cryptography to version 42.0.0 or later

Additional context
The currently used version of the cryptography package (41.0.7) has a reported vulnerability.

A flaw was found in the python-cryptography package. This issue may allow a remote attacker to decrypt captured messages in TLS servers that use RSA key exchanges, which may lead to exposure of confidential or sensitive data.

The package should be upgraded to version 42.0.0 or later to patch it

CVE-2023-50782

@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Feb 13, 2024
@pvaneck
Copy link
Member

pvaneck commented Feb 13, 2024

Hey, thanks for the feedback! For the cryptography dependency, we do not pin the upper bound in any of our SDK packages.

Generally, the responsibility is on the user to ensure that the latest or patched version of cryptography is used in their applications. And users newly installing our packages will install the latest version of cryptography (assuming no other conflicts).

Where did you see the 41.0.7 as the "currently used version"?

For our CI, I see that since we pin a pyopenssl dependency used in our test tooling, this forces a cryptography version less than that of the patched version. We can look into bumping this to ensure that the latest gets used.

@xiangyan99 xiangyan99 added needs-author-feedback Workflow: More information is needed from author to address the issue. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Feb 13, 2024
Copy link

Hi @mansi1597. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

@pvaneck
Copy link
Member

pvaneck commented Feb 13, 2024

Our CI should now be pulling in the latest cryptography after this change: #34307

I don't believe anything else should prevent users from pulling the latest cryptography, so I will close this as resolved.

@pvaneck pvaneck closed this as completed Feb 13, 2024
@mansi1597
Copy link
Author

Hey @pvaneck , Thanks for getting back to me. We were using an older version of pyopenssl which was causing this vulnerability. Updating it to pyopenssl 24.0.0 fixed the issue. Thanks for you help :)

@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-author-feedback Workflow: More information is needed from author to address the issue. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

No branches or pull requests

3 participants