Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No BreakingChangeReviewRequired label for breaking change #4199

Closed
mikekistler opened this issue Sep 21, 2022 · 2 comments
Closed

No BreakingChangeReviewRequired label for breaking change #4199

mikekistler opened this issue Sep 21, 2022 · 2 comments
Assignees
@jianyexi
Labels
Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@mikekistler
Copy link
Member

I'm still struggling to understand the rules for when the PR pipeline checks will add the BreakingChangeReviewRequired label to a PR.

PR 20762 failed the "Breaking Changes - Cross Version" PR check:

image

The API has a GA version and a new preview is breaking from that.

The openapi-pipeline-app added labels but not BreakingChangesReviewRequired.

image

Why?
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 21, 2022
@mikekistler mikekistler added Spec PR Tools Tooling that runs in azure-rest-api-specs repo. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Sep 21, 2022
@raych1
Copy link
Member

raych1 commented Oct 14, 2022 •
edited
Loading

@jianyexi , can you confirm if this is fixed?

@jianyexi
Copy link

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jianyexi jianyexi

Labels
Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Spec PR Tools
Status: 🎊 Closed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@raych1 @jianyexi @mikekistler