Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] appsetting.json and identity federation helper class should explain more what it's for, not the implementation detail #1699

Closed
jmprieur opened this issue Apr 9, 2022 · 1 comment

Comments

@jmprieur
Copy link
Collaborator

jmprieur commented Apr 9, 2022

Which version of Microsoft Identity Web are you using?
not released yet

Why?
From the point of view of a developer, what matters is that they want to avoid having to provide client secrets and client certificates. but that's not what the following tells us. It talks about implementation details (using identity federation in MSAL).

"IdentityFederation": {
 "IsEnabled": true, 
 "SubjectIdentifier": "02c0b640-8e3d-405e-999d-4781f2f0438a"
}

Before we release Id.Web, I propose we change the name of these settings to something like:

"ClientCredentialsUsingManagedIdentity": {
   "IsEnabled": true,
    "ManagedIdentityObjectId": "02c0b640-8e3d-405e-999d-4781f2f0438a"
}

We would also want to rename AzureFederatedTokenProvider to MsiClientAssertion

@jmprieur jmprieur added the fixed label Apr 19, 2022
@jennyf19 jennyf19 added this to the 1.24.0 milestone Apr 20, 2022
@jennyf19
Copy link
Collaborator

Released in 1.24.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants