Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] DefaultCertificateLoader does not accept that name : LocalComputer #1702

Closed
brentschmaltz opened this issue Apr 11, 2022 · 7 comments
Closed
Assignees
Labels
documentation Improvements or additions to documentation fixed
Milestone

Comments

@brentschmaltz
Copy link
Member

brentschmaltz commented Apr 11, 2022

Which version of Microsoft Identity Web are you using?
master

To repo:

  1. Create a CertificateDescription with CertificateStorePath = "LocalComputer/My".
  2. Try and load the cert.

The error has the following message:

IDW10703: Certificate store path must be of the form 'StoreLocation/StoreName'. StoreLocation must be one of 'CurrentUser', 'CurrentMachine'. StoreName must be empty or one of 'AddressBook', 'AuthRoot', 'CertificateAuthority', 'Disallowed', 'My', 'Root', 'TrustedPeople', 'TrustedPublisher'.

If you open up MMC the common names are: "CurrentUser" and "LocalComputer"
Since you already have support for "CurrentMachine", please add support for "LocalComputer".

See this document for names.

I is always a good idea to echo what was received.
The above error message could be written"
IDW10703: The Certificate store path received '.......' was not of the form....

@jennyf19
Copy link
Collaborator

@brentschmaltz Not sure what the issue is. We are parsing the values out here, and using CurrentUser as the default.

The only values for StoreLocation are CurrentUser and LocalMachine:
image

@brentschmaltz
Copy link
Member Author

@jennyf19 there is no 'CurrentMachine'. Your error message, IDW10703, includes the name: 'CurrentMachine', it should be 'LocalMachine'.

@jennyf19
Copy link
Collaborator

@brentschmaltz That's not what the issue says above, but thanks for clarifying. Will fix the error message.

@jennyf19
Copy link
Collaborator

fixed in #1704

@jennyf19 jennyf19 added documentation Improvements or additions to documentation fixed labels Apr 14, 2022
@jennyf19 jennyf19 self-assigned this Apr 14, 2022
@brentschmaltz
Copy link
Member Author

@jennyf19 thanks for fixing, when i wrote the bug i was confused because of the error message.
Your explanation helped me understand what the issue was.
Sorry for the confusion.

@jennyf19
Copy link
Collaborator

@brentschmaltz it's fine! I was confused too so thanks for the explanation. I'll re-open until we release the updated message and then close.

@jennyf19 jennyf19 reopened this Apr 14, 2022
@jennyf19 jennyf19 added this to the 1.24.0 milestone Apr 20, 2022
@jennyf19
Copy link
Collaborator

Released in 1.24.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation fixed
Projects
None yet
Development

No branches or pull requests

2 participants