Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Token cache serialization should expose their own options #251

Closed
jmprieur opened this issue Jun 24, 2020 · 1 comment
Closed

[Bug] Token cache serialization should expose their own options #251

jmprieur opened this issue Jun 24, 2020 · 1 comment

Comments

@jmprieur
Copy link
Collaborator

jmprieur commented Jun 24, 2020

Which Version of Microsoft Identity Web are you using ?
Microsoft Identity Web 0.1.5-preview

MsalMemoryTokenCacheProvider get its own options type but MsalDistributedTokenCacheAdapter injects IOptions<DistributedCacheEntryOptions> ?

It's historical and needs to be changed
We should not inject the IOptions<DistributedCacheEntryOptions> (because different components could be using different caches and would need to have different options)

What needs to be done?

  • SessionTokenCache does not need option, it uses the session options
  • MsalMemoryTokenCacheProvider.cs already has options, which we'll keep.
  • Add a MsalDistributedTokenCacheAdapterOptions class inheriting from DistributedCacheEntryOptions, and use this one in lieu of DistributedCacheEntryOptions in MsalDistributedTokenCacheAdapter.cs (as other components would want to use the ASP.NET Core provided distributed cache)
  • update the wiki documentation to mention the new option.
@jennyf19
Copy link
Collaborator

Included in 0.2.0-preview release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants