Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] In templates, Services\DownstreamWebApi.cs, CallWebApi should be named CalledWebApiAsync #357

Closed
jmprieur opened this issue Jul 23, 2020 · 1 comment
Closed

[Bug] In templates, Services\DownstreamWebApi.cs, CallWebApi should be named CalledWebApiAsync #357

jmprieur opened this issue Jul 23, 2020 · 1 comment
Assignees
@jennyf19
Labels
bug Something isn't working fixed P2
Milestone
[2] .NET5 preview 8

Comments

@jmprieur
Copy link
Collaborator

Which version of Microsoft Identity Web are you using?

  • Look at the DownstreamWebApi.cs files
  • allWebApi is async and should be named CalledWebApiAsync

also change where it's called:

  • .razor pages
  • controllers.
  • .cshtm.cs
@jmprieur jmprieur added bug Something isn't working P2 labels Jul 23, 2020
@jmprieur jmprieur added this to the [2] .NET5 preview 8 milestone Jul 23, 2020
@jennyf19 jennyf19 self-assigned this Jul 23, 2020
@jennyf19 jennyf19 mentioned this issue Jul 23, 2020
Merged
@jennyf19 jennyf19 added the fixed label Jul 23, 2020
@pmaytak
Copy link
Contributor

pmaytak commented Jul 25, 2020

Included in Microsoft Identity Web 0.2.1-preview release.

@pmaytak pmaytak closed this as completed Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennyf19 jennyf19

Labels
bug Something isn't working fixed P2
Projects
None yet
Milestone
[2] .NET5 preview 8
Development

No branches or pull requests
3 participants
@jmprieur @jennyf19 @pmaytak