Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background permission getting added in the merged manifest #53

Closed
rananhffc opened this issue Sep 27, 2021 · 9 comments
Closed

Background permission getting added in the merged manifest #53

rananhffc opened this issue Sep 27, 2021 · 9 comments
Milestone

Comments

@rananhffc
Copy link

Describe the bug
I loved locus, the implementation was really easy and it handles everything but the only issue is that I do not need background location updates, i only need it on demand, but after implementing locus Background permission is getting added to the merged manifest as well and so i have an issue in uploading it on the play store.

To Reproduce
Steps to reproduce the behavior:

  1. Import locus
  2. Check merged manifest
    Expected behavior

As mentioned i require the location only on demand, so is it possible to get only that and not have to take the background location permission?

Thanks in advance!
Screenshot 2021-09-27 at 1 24 24 PM
ce

@BirjuVachhani
Copy link
Owner

BirjuVachhani commented Sep 28, 2021

The permission is added into the manifest file of the library. Perhaps I need to make it explicit so the user if wants to use background location. needs to add the permission in the manifest file manually! I think that could work.

@rananhffc
Copy link
Author

yes that would be helpful and would solve the issue, do close this once you have made the change so that i get informed, i will then reimplement it in my app. Thanks for the wonderful work!

@BirjuVachhani BirjuVachhani added the enhancement New feature or request label Sep 29, 2021
@BirjuVachhani BirjuVachhani added this to the v4.0.0 milestone Sep 29, 2021
@iChintanSoni
Copy link
Collaborator

As an alternative, you can place below tag in your manifest:

<uses-permission tools:node="remove" android:name="android.permission.ACCESS_BACKGROUND_LOCATION" />

@BirjuVachhani
Copy link
Owner

Awesome! I didn't know that. Thanks @iChintanSoni. @rananhffc Does this help in your case? If it does, then I will add this as a note in the readme for other fellow developers who may face what you're facing. Let me know if this works for you!

@BirjuVachhani BirjuVachhani removed the enhancement New feature or request label Sep 30, 2021
@BirjuVachhani
Copy link
Owner

@rananhffc Did you get a chance to try this? Let me know if you did.

@rananhffc
Copy link
Author

hi sorry for the delay in reply, i am yet to implement the manifest remove line, will probably do it by end of this month, but im quite confident that will solve the issue, soo will close this issue. Thanks a ton!

@BirjuVachhani
Copy link
Owner

Great. I'll add this to documentation. Let me know if this does not work. Thanks.

@russellhoff
Copy link

This week, I haven0t been able to publish my app since Google denied it. The reason? The merged AndroidManifest.xml had the background permission. I removed it as you suggested and they still denied it.

@Afaquejaya
Copy link

This week, I haven0t been able to publish my app since Google denied it. The reason? The merged AndroidManifest.xml had the background permission. I removed it as you suggested and they still denied it.

Did you add below the line in your manifest?
<uses-permission tools:node="remove" android:name="android.permission.ACCESS_BACKGROUND_LOCATION" />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants