Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPU_HUFFMAN_ZLIB Compressor Doesn't Use Huffman Coding #192

Open
ben-e-whitney opened this issue Jun 10, 2022 · 0 comments · May be fixed by #196
Open

CPU_HUFFMAN_ZLIB Compressor Doesn't Use Huffman Coding #192

ben-e-whitney opened this issue Jun 10, 2022 · 0 comments · May be fixed by #196
Assignees
@ben-e-whitney
Labels
enhancement New feature or request

Comments

@ben-e-whitney
Copy link
Collaborator

ben-e-whitney commented Jun 10, 2022 •
edited
Loading

When the lossless compressor is set to CPU_HUFFMAN_ZLIB in the header, Huffman coding is not applied to the quantized coefficients before they are passed to compress_memory_z. See this case. We should rename the enumeration value to CPU_ZLIB and add a case where both Huffman coding and compress_memory_z are applied.
@ben-e-whitney ben-e-whitney self-assigned this Jun 10, 2022
@ben-e-whitney ben-e-whitney added the enhancement New feature or request label Jun 10, 2022
@ben-e-whitney ben-e-whitney changed the title CPU_HUFFMAN_ZLIB Compressor Doesn't Use Huffman coding CPU_HUFFMAN_ZLIB Compressor Doesn't Use Huffman Coding Jun 10, 2022
@ben-e-whitney ben-e-whitney linked a pull request Jun 28, 2022 that will close this issue
Rewrite Huffman Coding Implementation #196
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ben-e-whitney ben-e-whitney

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite Huffman Coding Implementation CODARcode/MGARD
1 participant
@ben-e-whitney