Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several nothrow things #38

Open
ghost opened this issue Apr 17, 2019 · 0 comments
Open

Several nothrow things #38

ghost opened this issue Apr 17, 2019 · 0 comments

Comments

@ghost
Copy link

ghost commented Apr 17, 2019

  1. Not all extern blocks are marked with nothrow. Namely, only curses.d has one, the rest do not.
  2. Not all function arguments and fields are nothrow. In forms API, all of the structs' fields can hold a throwing function. In curses.d, vidputs and ripoffline can accept throwing functions as well, since nothrow on the enclosing block is not applied transitively to the argument functions.

The first point is very easy to fix, and I will make a pull request shortly. The second one is not, fixing it will break existing code. Not fixing it is possibly dangerous, I'm not sure what the C side would do if a function passed to it throws.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants