Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow chaining commands in bender #20

Open
arthursoprana opened this issue Oct 19, 2020 · 7 comments
Open

Allow chaining commands in bender #20

arthursoprana opened this issue Oct 19, 2020 · 7 comments

Comments

@arthursoprana
Copy link

The idea is that the user would be able to to the following (perhaps with a different syntax)

!build <some-job-name> !merge <branch-name>

Which means that, after the command !build finishes, call the command !merge.

@tigarmo
Copy link

tigarmo commented Oct 19, 2020

But only if the first command succeeds, right? Do we have a notion of "success" for bender commands?

@prusse-martin
Copy link
Member

The "build" command succeed when bender can trigger the job.
The job build state change is another event.

@tigarmo
Copy link

tigarmo commented Oct 19, 2020

Then that's something to consider, because I imagine that we don't want to merge if the job triggered by the build command fails

@gcardozo123
Copy link

merge is actually implemented on err-stash here and for now we don't know whether it succeeded or not.

@prusse-martin
Copy link
Member

I think this comes in line with the proposed gate keeper. I don't think we have it in our short time planning.

@prusse-martin
Copy link
Member

Another thing that should be considered.
If the triggered job succeeds and that cause another downstream job to be started?
A merge could fail since stash already know there is another build for that commit running;
Or bender could try to merge before jenkins notify about the build and the merge and branch deletion happens. I don't have idea of what will happen if jobs_done try to remove a job with an ongoing build.

@arthursoprana
Copy link
Author

Then that's something to consider, because I imagine that we don't want to merge if the job triggered by the build command fails

True @tigarmo, this process of build followed by merge would only be safe if a merge check of minimum number of successful builds is enabled in stash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants