Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offers: not getting invoice back after sending invoice request for CLN offer #7110

Closed
orbitalturtle opened this issue Feb 27, 2024 · 2 comments · Fixed by #7304
Closed

Offers: not getting invoice back after sending invoice request for CLN offer #7110

orbitalturtle opened this issue Feb 27, 2024 · 2 comments · Fixed by #7304
Assignees
Labels
protocol These issues are protocol level issues that should be discussed on the protocol spec repo
Milestone

Comments

@orbitalturtle
Copy link
Contributor

Issue and Steps to Reproduce

I think @TheBlueMatt already reported this issue offline but I wanted to create an issue to keep tabs on it.

It seems in some cases CLN doesn't send an invoice back when it can't find a route to the introduction node of a blinded path provided by an invoice request. CLN might want to just direct connect to the introduction node, which is what LDK does for now while onion messaging support is still low

As for reproducing this issue, personally the setup I had when running into this was... Had a network of test nodes like so:

LND <-> CLN <-> CLN2

On top of the LND node I run LNDK, in particular this branch, which in turn uses LDK to manage the offers flow, invoice requests, waiting for an invoice, and all that jazz.

CLN2 creates the offer and we pay with LNDK. We send an invoice request out but don't get the invoice back.

@rustyrussell
Copy link
Contributor

Yeah, this is because we figure out the route first (or if we have to direct connect) then create the return route exactly backwards from that, so it always starts at the destination. I have WIP patch to direct connect in this case, but it is a bit more complex because we don't want someone to be able to DoS us by making us connect to everyone on the network, so we need the concept of "transient" connections, hence it didn't make this release.

@vincenzopalazzo vincenzopalazzo added the protocol These issues are protocol level issues that should be discussed on the protocol spec repo label Feb 27, 2024
@moneyball
Copy link

There are users hoping to support BOLT 12 running into this problem. Any idea on when it will be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol These issues are protocol level issues that should be discussed on the protocol spec repo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants