Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store config files less permissive and usable on multiuser systems #2

Closed
yolk opened this issue Oct 19, 2018 · 2 comments
Closed

Store config files less permissive and usable on multiuser systems #2

yolk opened this issue Oct 19, 2018 · 2 comments
Assignees
Labels

Comments

@yolk
Copy link
Contributor

yolk commented Oct 19, 2018

When using mite config set [key] [value] mite-cli stores the given values in a config.json file lovated inside node_modules/mite-cli. This has two issues:

  1. The file config.json is world-readable by any user/process on my system and contains sensitive informations. The permissions should be 640 or even better just 600.

  2. The file is located outside of my users home folder. Other users using the same machine will see/overwrite my mite-cli file. Maybe it would be better to use a file in ~/.mite-cli.json instead?

@Ephigenia Ephigenia added the bug label Nov 2, 2018
@Ephigenia
Copy link
Owner

This is in fact a bug as I never thought about where the file would be stored when installing mite-cli. I’m going to fix it in a way where the config file is stored in the user’s home directory.

@Ephigenia Ephigenia self-assigned this Nov 2, 2018
@Ephigenia
Copy link
Owner

Fixed in v0.6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants