Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacktrace doesn't show up on Android Studio #35

Closed
Sloy opened this issue Jun 15, 2017 · 2 comments
Closed

Stacktrace doesn't show up on Android Studio #35

Sloy opened this issue Jun 15, 2017 · 2 comments
Milestone

Comments

@Sloy
Copy link
Contributor

Sloy commented Jun 15, 2017

Hi!

Android Studio only shows the logcat of the current process by default.
Since the library restarts the process to show the error Activity, and the stacktrace of the crash is logged in the old process, Android Studio doesn't show the stacktrace after a crash. You need to change the filters, or remove them, showing a lot of unwanted verbose information.

So, here's my idea for that problem:
The library could log the info in getStackTraceFromIntent() or getAllErrorDetailsFromIntent() from the error Activity. This way the developer will see it in Android Studio without changing the filter. The info will be duplicated in the full logcat, but I think its an acceptable trade-off.

That's what I've done in our custom error Activity at InfoJobs, but I think it could be a helpful addition to the library itself.

What do you think?
Thanks again for the library @Ereza, you know we're happy users of it :)

@Ereza
Copy link
Owner

Ereza commented Jun 15, 2017

Hi @Sloy, thanks again for the positive feedback! Yes, that's an issue I have faced myself, and I think it would indeed be a nice addition. I'll add it :)

@Ereza Ereza closed this as completed in 5b71775 Nov 13, 2017
@Ereza Ereza added this to the 2.2.0 milestone Nov 13, 2017
@Ereza
Copy link
Owner

Ereza commented Nov 13, 2017

Done in 2.2.0. Thanks again for the suggestion ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants