Indentation for temporal tables in OnModelCreating is a bit wonky

[CaiusJard]

Steps to reproduce

I just created a normal table, turned it temporal with an ALTER and then did an EFCPT rev engineer

Further technical details

EF Core version in use: EF Core 6

EF Core Power Tools version: current daily 2.5.902

Database engine: SQL Server 2017

Visual Studio version: 2022 17.0.5

[ErikEJ]

Possible EF Core issue @roji ?

[ErikEJ]

@CaiusJard Are you using DbContext splitting?

[CaiusJard]

No splitting - here's what I have configured:

Here's the table create script:

/****** Object:  Table [dbo].[Containers]    Script Date: 2022-02-01 17:34:39 ******/
SET ANSI_NULLS ON
GO

SET QUOTED_IDENTIFIER ON
GO

CREATE TABLE [dbo].[Containers](
	[ContainerId] [int] IDENTITY(1,1) NOT NULL,
	[HierarchyId] [hierarchyid] NOT NULL,
	[Name] [varchar](50) NOT NULL,
	[SysStartTime] [datetime2](7) GENERATED ALWAYS AS ROW START NOT NULL,
	[SysEndTime] [datetime2](7) GENERATED ALWAYS AS ROW END NOT NULL,
 CONSTRAINT [PK_Containers] PRIMARY KEY CLUSTERED 
(
	[ContainerId] ASC
)WITH (PAD_INDEX = OFF, STATISTICS_NORECOMPUTE = OFF, IGNORE_DUP_KEY = OFF, ALLOW_ROW_LOCKS = ON, ALLOW_PAGE_LOCKS = ON) ON [PRIMARY],
	PERIOD FOR SYSTEM_TIME ([SysStartTime], [SysEndTime])
) ON [PRIMARY]
WITH
(
SYSTEM_VERSIONING = ON ( HISTORY_TABLE = [dbo].[MSSQL_TemporalHistoryFor_434100587] )
)
GO

ALTER TABLE [dbo].[Containers] ADD  CONSTRAINT [DF_SysStart]  DEFAULT (sysutcdatetime()) FOR [SysStartTime]
GO

ALTER TABLE [dbo].[Containers] ADD  CONSTRAINT [DF_SysEnd]  DEFAULT (CONVERT([datetime2],'9999-12-31 23:59:59.9999999')) FOR [SysEndTime]
GO

SQLS2017

I just went and took that script, changed all the names to have 2 on the end and made another table and rev'd it.. Indentation also comes through short on that one, so hopefully it will help you repro (sorry for omitting the detail earlier)

[ErikEJ]

It is an EF Core Bug and will be fixed in EF Core 7 🤥 dotnet/efcore#26349