Can someone please tell me what's wrong with this script?

[sword0115]

I've made a script for one of my songs to play dialogue at the start and end of the song, from looking at it I feel like it should work but I've never used haxe before so I don't know

the game says there's an unexpected "{" on line 93 but to me that seems to be in the correct position, and if I remove it it breaks the script in a different way

import flixel.tweens.FlxEase;
import funkin.graphics.FunkinSprite;
import flixel.tweens.FlxTween;
import funkin.Paths;
import funkin.play.cutscene.dialogue.DialogueBox;
import funkin.play.PlayState;
import funkin.play.PlayStatePlaylist;
import funkin.play.song.Song;
import flixel.FlxG;
import flixel.FlxSprite;

class WithaBangSong extends Song {
  var hasPlayedCutscene:Bool;
  var hasPlayedEndCutscene:Bool;

	public function new() {
		super('With-a-Bang');
	}

  public override function onCountdownStart(event:CountdownScriptEvent):Void {
		super.onCountdownStart(event);

    if (!PlayStatePlaylist.isStoryMode) hasPlayedCutscene = true;

    if (!hasPlayedCutscene) {
      trace('Pausing countdown to play cutscene.');

      hasPlayedCutscene = true;

      event.cancel(); // CANCEL THE COUNTDOWN!

      PlayState.instance.currentStage.pause();

      transitionToDialogue();
    }
	}

  function transitionToDialogue() {
    trace('Transitioning to dialogue.');

    PlayState.instance.camCutscene.visible = true;

    var black:FlxSprite = new FunkinSprite(-20, -20).makeSolidColor(FlxG.width * 1.5, FlxG.height * 1.5, 0xFF000000);
    black.cameras = [PlayState.instance.camCutscene];
    black.zIndex = 1000000;
    PlayState.instance.add(black);

    black.alpha = 1.0;

    var tweenFunction = function(x) {
      var xSnapped = Math.floor(x * 8) / 8;
      black.alpha = 1.0 - xSnapped;
    };

    FlxTween.num(0.0, 1.0, 2.0, {
      ease: FlxEase.linear,
      startDelay: 0.25,
      onComplete: function (input) {

        // black.visible = false;
        startDialogue();
      }
    }, tweenFunction);
  }

  function startDialogue() {
    PlayState.instance.startConversation('With-a-Bang-start');
  }


  public override function onDialogueEnd() {
    // We may need to wait for the outro to play.
    PlayState.instance.currentStage.resume();
    Countdown.performCountdown();
  }

  public override function onSongEnd(event:CountdownScriptEvent):Void {
		super.onSongEnd(event);

		// Keep the cutscene from playing outside of story mode.
    if (!PlayStatePlaylist.isStoryMode) hasPlayedEndCutscene = true;

    if (!hasPlayedEndCutscene) {
      trace('Pausing countdown to play cutscene.');

      hasPlayedEndCutscene = true;

      event.cancel(); // CANCEL THE COUNTDOWN!

      PlayState.instance.currentStage.pause();
	  
	  startEndDialogue()
	  }   //This is line 93, the one the game insists is incorrect
	  }
	


  function startEndDialogue() {
    PlayState.instance.startConversation('With-a-Bang-end');
  }
  
   public override function onDialogueEnd() {
    // We may need to wait for the outro to play.
    PlayState.instance.currentStage.resume();
}
   
  /**
   * Don't replay the cutscenes between restarts.
   */
  function onSongRetry(event:ScriptEvent)
  {
    super.onSongRetry(event);

    hasPlayedCutscene = true;
	
    hasPlayedEndCutscene = true;
  }

  /**
   * Replay the cutscenes after leaving the song.
   */
  function onCreate(event:ScriptEvent):Void
  {
    super.onCreate(event);
	
	hasPlayedCutscene = false;

    hasPlayedEndCutscene = false;
  }
  

}

[NotHyper-474]

I guess it's the fact that startEndDialogue() is missing a semicolon at the end.

[sword0115]

Thanks for the response! I actually already fixed that issue but now I have a new one, after the end dialogue finishes the song doesn't end. Instead it leaves me in a softlocked state where I can't do anything (can't even pause the game to quit the song)
Any idea how to fix this?

import flixel.tweens.FlxEase;
import funkin.graphics.FunkinSprite;
import flixel.tweens.FlxTween;
import funkin.Paths;
import funkin.play.cutscene.dialogue.DialogueBox;
import funkin.play.PlayState;
import funkin.play.PlayStatePlaylist;
import funkin.play.song.Song;
import flixel.FlxG;
import flixel.FlxSprite;

class WithaBangSong extends Song {
  var hasPlayedCutscene:Bool;
  var hasPlayedEndCutscene:Bool;

	public function new() {
		super('With-a-Bang');
	}

  public override function onCountdownStart(event:CountdownScriptEvent):Void {
		super.onCountdownStart(event);

    if (!PlayStatePlaylist.isStoryMode) hasPlayedCutscene = true;

    if (!hasPlayedCutscene) {
      trace('Pausing countdown to play cutscene.');

      hasPlayedCutscene = true;

      event.cancel(); // CANCEL THE COUNTDOWN!

      PlayState.instance.currentStage.pause();

      transitionToDialogue();
    }
	}

  function transitionToDialogue() {
    trace('Transitioning to dialogue.');

    PlayState.instance.camCutscene.visible = true;

    var black:FlxSprite = new FunkinSprite(-20, -20).makeSolidColor(FlxG.width * 1.5, FlxG.height * 1.5, 0xFF000000);
    black.cameras = [PlayState.instance.camCutscene];
    black.zIndex = 1000000;
    PlayState.instance.add(black);

    black.alpha = 1.0;

    var tweenFunction = function(x) {
      var xSnapped = Math.floor(x * 8) / 8;
      black.alpha = 1.0 - xSnapped;
    };

    FlxTween.num(0.0, 1.0, 2.0, {
      ease: FlxEase.linear,
      startDelay: 0.25,
      onComplete: function (input) {

        // black.visible = false;
        startDialogue();
      }
    }, tweenFunction);
  }

  function startDialogue() {
    PlayState.instance.startConversation('With-a-Bang-start');
  }


  public override function onDialogueEnd() {
    // We may need to wait for the outro to play.
    PlayState.instance.currentStage.resume();
    Countdown.performCountdown();
  }

  public override function onSongEnd(event:CountdownScriptEvent):Void {
		super.onSongEnd(event);

		// Keep the cutscene from playing outside of story mode.
    if (!PlayStatePlaylist.isStoryMode) hasPlayedEndCutscene = true;

    if (!hasPlayedEndCutscene) {
      trace('Pausing countdown to play cutscene.');

      hasPlayedEndCutscene = true;

      event.cancel(); // CANCEL THE COUNTDOWN!

      PlayState.instance.currentStage.pause();

      transitionToEndDialogue();
    }
	}

  function transitionToEndDialogue() {
    trace('Hit end of song! Starting outro.');

    PlayState.instance.camCutscene.visible = true;

        startEndDialogue();
      }
  
  function startEndDialogue() {
    PlayState.instance.startConversation('With-a-Bang-end');
  }
  
   public override function onEndDialogueEnd() {
    // We may need to wait for the outro to play.
	PlayState.instance.currentStage.resume();
	PlayState.instance.endSong();
}


  /**
   * Don't replay the cutscenes between restarts.
   */
  function onSongRetry(event:ScriptEvent)
  {
    super.onSongRetry(event);

    hasPlayedCutscene = true;
	
  }

  /**
   * Replay the cutscenes after leaving the song.
   */
  function onCreate(event:ScriptEvent):Void
  {
    super.onCreate(event);
	
	hasPlayedCutscene = false;

    hasPlayedEndCutscene = false;
  }
  

}

^updated script, everything works perfectly but song doesn't end

[NotHyper-474]

There's some stuff to notice here:

public override function onEndDialogueEnd()
    {
      // We may need to wait for the outro to play.
      PlayState.instance.currentStage.resume();
      PlayState.instance.endSong();
  }

This function will never be called because it isn't valid, there's no "onEndDialogueEnd" implemented in the script system.
But seems like that won't matter anyway because onDialogueEnd is never called either.

A workaround I found was to override onScriptEvent and check if the type is DIALOGUE_END and call the function from there:

public override function onScriptEvent(event:ScriptEvent):Void
  {
    super.onScriptEvent(event);
    // Workaround as onDialogueEnd doesn't actually get automatically called
    if (event.type == "DIALOGUE_END") onDialogueEnd();
  }

There must be a better way of doing this but it works for now.

Also for the onEndDialogueEnd I did this instead in onDialogueEnd:

public override function onDialogueEnd()
  {
    PlayState.instance.currentStage.resume();

    if (!hasFinishedStartDialogue)
    {
      // Not really needed as PlayState will automatically start countdown when a cutscene/dialogue finishes
      Countdown.performCountdown();
      hasFinishedStartDialogue = true;
    }
    else
    {
      // Note: This will immediately jump to the next song and ignore the dialogue box fade out, I recommend using a timer here
      PlayState.instance.endSong();
    }
  }