Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element-wise face culling #162

Open
muzikbike opened this issue May 13, 2023 · 1 comment
Open

Element-wise face culling #162

muzikbike opened this issue May 13, 2023 · 1 comment
Labels
suggestion A suggestion, enhancement, feature or request

Comments

@muzikbike
Copy link

Stairs are made out of two cuboids: one for the lower slab portion, and another for the upper quarter of a block section. Culling, however, is solely based on the whole block's collision box, causing some quads to still be rendered in situations like the following, when they are fully obscured:
2023-05-13_16 22 09
2023-05-13_16 22 36

In these situations, we could probably get rid of some more faces:
2023-05-13_16 22 22
2023-05-13_16 22 31
2023-05-13_16 22 49
2023-05-13_16 22 55

@FxMorin
Copy link
Owner

FxMorin commented Jan 7, 2024

The minecraft code is not built in a way that would make this easy. I also don't think there would be enough instances of a match like this happening. to justify the cost of that many more checks. So ill put this on the back burner

@FxMorin FxMorin added the suggestion A suggestion, enhancement, feature or request label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion A suggestion, enhancement, feature or request
Projects
None yet
Development

No branches or pull requests

2 participants