Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would be nice to have the button separate from the modal #13

Open
samzhao opened this issue Jun 19, 2015 · 0 comments
Open

Would be nice to have the button separate from the modal #13

samzhao opened this issue Jun 19, 2015 · 0 comments

Comments

@samzhao
Copy link

samzhao commented Jun 19, 2015

Hey guys,

Thanks for the amazing work! I know this component doesn't work, yet, but all the styles and interactions are super nice :D

I was just wondering that it would be really nice if the button and modal itself are separate components. React Portal simply let you pass in a custom component to activate it if you so wish <Portal openByClickOn={button1}>. OR, to simplify things more, we can even get rid of the button from the DateSelect component and only allow the user to control it using the isOpen prop, just like how you guys did it with the Elemental Modal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant