Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up warning due to unused generic type parameter #34

Closed
rbeeli opened this issue Dec 6, 2023 · 2 comments
Closed

Clean-up warning due to unused generic type parameter #34

rbeeli opened this issue Dec 6, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@rbeeli
Copy link
Contributor

rbeeli commented Dec 6, 2023

With the latest version of ClickHouse.jl, we get some ugly warnings due to unused type variables. Could those be removed? Should be a rather easy fix.

 ClickHouse [82f2e89e-b495-11e9-1d9d-fb40d7cf2130]
│  WARNING: method definition for write_col_data at /home/rino/.julia/packages/ClickHouse/j7XeK/src/columns/Nullable.jl:92 declares type variable T but does not use it.
│  WARNING: method definition for insert at /home/rino/.julia/packages/ClickHouse/j7XeK/src/Query.jl:80 declares type variable T but does not use it.
└

Thanks.
@athre0z athre0z added the enhancement New feature or request label Dec 6, 2023
@athre0z
Copy link
Member

athre0z commented Dec 6, 2023

I don't really use Julia anymore and the other maintainer, @waralex, hasn't had any activity on GitHub for about a year. I'm still happy to review PRs though.

@rbeeli rbeeli mentioned this issue Dec 7, 2023
Merged
@quinnj
Copy link
Member

quinnj commented Dec 9, 2023

Fixed in #35

@quinnj quinnj closed this as completed Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@quinnj @athre0z @rbeeli