Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Robustly Support ODBC Connection #5

Open
TheCedarPrince opened this issue Mar 14, 2023 · 0 comments
Open

[FEATURE] Robustly Support ODBC Connection #5

TheCedarPrince opened this issue Mar 14, 2023 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@TheCedarPrince
Copy link
Collaborator

As of right now, ODBC support via ODBC.jl is perfunctory at best within DBConnector. It is not clear to me how much to offload to a user of an ODBC connection or if we should automatically install and set-up ODBC connections. Due to the variation of ODBC drivers, it seems like the most logical step is to require users to set up ODBC connections themselves. @quinnj , would you be able to comment on this approach overall?

Additionally, the way that I understand ODBC.jl is that ideally a _dbconnect dispatch should support the following functionality:

  1. Allow a user to either give a path to an ODBC driver or have DBConnector perhaps choose the most logical driver
  2. Allow the user to specify the type of dbms they are using so as to potentially anticipate inconsistency between ODBC drivers
  3. Enable users to pass in any count of kwargs
  4. Construct connection string for that specific DBMS instance via their respective ODBC driver
  5. Create a DBInterface.Connection successfully

I feel like there may be other sorts of functionality that will need to be created in the future specific to a particular DBMS instance such that we will create file structures like src/odbc/odbc_sql_server.jl or something to that effect. But that may be overcomplicating things.

Either way, I am open to ideas, suggestions, and thoughts here.

@TheCedarPrince TheCedarPrince added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant