Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename remaining of static constructor methods. #454

Closed
11 tasks done
kezz opened this issue Sep 28, 2021 · 2 comments · Fixed by #923
Closed
11 tasks done

Rename remaining of static constructor methods. #454

kezz opened this issue Sep 28, 2021 · 2 comments · Fixed by #923
Labels
good first issue type: enhancement

Comments

@kezz
Copy link
Member

kezz commented Sep 28, 2021 •
edited by zml2008
Loading

  • BlockNBTComponent.LocalPos.of
  • BlockNBTComponent.WorldPos.of
  • NamedTextColor.ofExact
  • Style.Merge.of
  • HoverEvent.ShowItem.of
  • BinaryTagHolder.of
  • adventure-nbt tag constructors
  • KeyedValue.of
  • Codec.of
  • HSVLike.of
  • GlobalTranslator.get
@CoreyShupe
Copy link

What should these be renamed to? Is there a standard for static constructors.

@kezz
Copy link
Member Author

kezz commented Oct 24, 2021

What should these be renamed to? Is there a standard for static constructors.

Ideally, the name of the thing that is being constructed. For example, HSVLike.of -> HSVLike.hsvLike.

@KingOfSquares KingOfSquares mentioned this issue Dec 22, 2021
Merged
@powercasgamer powercasgamer mentioned this issue May 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: rename static constructors powercasgamer/adventure
2 participants
@kezz @CoreyShupe