Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key is parsable despite documented otherwise #919

Closed
imDaniX opened this issue May 10, 2023 · 1 comment · Fixed by #925
Closed

Key is parsable despite documented otherwise #919

imDaniX opened this issue May 10, 2023 · 1 comment · Fixed by #925

Comments

@imDaniX
Copy link

imDaniX commented May 10, 2023

String :my_key is parsable into minecraft:my_key, but it doesn't follow the documented pattern ([a-z0-9_\\-.]+:)?[a-z0-9_\\-./]+ - the pattern requires at least one symbol for the namespace if such is used.

@imDaniX
Copy link
Author

imDaniX commented May 11, 2023

Just wanna note that it's likely not a bug, but rather a problem with used @Pattern, as such case (:my_key) is actually mentioned in the javadoc itself. Maybe the used pattern ([a-z0-9_\\-.]+:)? better be changed to ([a-z0-9_\\-.]*:)? instead.

But I'd say I find it weird that such key is actually parsable into anything, as it doesn't make much sense for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants