Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using a light color palette, input text is barely visible #3

Closed
pablobh opened this issue Jul 22, 2020 · 0 comments
Closed

When using a light color palette, input text is barely visible #3

pablobh opened this issue Jul 22, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@pablobh
Copy link
Contributor

pablobh commented Jul 22, 2020

Problem

If you use a light color palette, the text on the inputs is barely visible.

Example

Here is my current color palette:

add_filter('login_color_palette', function () {
    return [
        'brand' => '#f3f3f3',
        'trim' => '#9d402d',
        'trim-alt' => '#f3f3f3',
    ];
});

This is how it looks:
Screenshot from 2020-07-21 19-23-45

As you can see, the text from the inputs is really hard to read.

Possible solution

Have an additional variable we can setup named "text" or something like that and have the inputs text use them.

Additional info

I'm using the latest version of the plugin. I think this may be related to #1

Bonus track

I know this plugin is supposed to be as simple as possible, but would it be too much to ask to add another variable for the login button? As you can see from my screenshot, the login button doesn't looks like a button, maybe add a little bit of shadow?

@Log1x Log1x added the bug Something isn't working label Jul 22, 2020
@Log1x Log1x self-assigned this Jul 22, 2020
@Log1x Log1x closed this as completed in 29c58fe Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants