Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest better error message than 'assert q.is_cuda and k.is_cuda and v.is_cuda' #112

Open
richelbilderbeek opened this issue Sep 9, 2024 · 2 comments

Comments

@richelbilderbeek
Copy link

Multiple issues (#11, #20, #34, #96) mention the same error:

assert q.is_cuda and k.is_cuda and v.is_cuda

#96 mentions a solution, from the author of this code:

please try pip uninstall triton and run the code again.

From that I'd like to conclude that code is run that expects Triton to be absent. Hence I suggest to make the error message more explicit:

Error: you are running code that expects Triton to be absent. Please uninstall Triton (`pip uninstall triton`) and run again.

In that way, us users know better what to do :-)

Of course, I may be wrong in interpreting what the error message should be. That shows the need to improve that error message even more 👍

@richelbilderbeek
Copy link
Author

Also here is a reproducible error, that only installs DNABERT 2, then runs the example script.

@richelbilderbeek
Copy link
Author

richelbilderbeek commented Sep 12, 2024

The error is incorrect. It should be:

Error: you are running code that uses Triton on hardware that does not support CUDA, i.e. not using NVIDIA hardware.

To run this code on regular CPUs uninstall Triton, e.g. with `pip uninstall triton` and run again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant