fix(webpack_config): remove url-loader duplication in server and clie…

…nt configs fix(webpack_config): remove url-loader duplication in server and client configs
Metnew · Nov 7, 2017 · 7cea591 · 7cea591
1 parent ba31463
commit 7cea591
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 27 deletions.
diff --git a/webpack_config/client/webpack.base.js b/webpack_config/client/webpack.base.js
@@ -70,20 +70,6 @@ const baseBuild = {
 			{
 				test: /\.(ico|eot|otf|webp|ttf|woff|woff2)$/i,
 				use: `file-loader?limit=100000&name=assets/[name].[hash:6].[ext]`
-			},
-			{
-				test: /\.(jpe?g|png|gif|svg)$/,
-				use: [
-					{
-						loader: 'url-loader',
-						options: {
-							limit: 4096,
-							// path: '/images',
-							name: 'images/[name].[hash:6].[ext]'
-						}
-					},
-					'img-loader'
-				]
 			}
 			// NOTE: LQIP loader doesn't work with file-loader and url-loader :(
 			// `npm i --save-dev lqip-loader`

diff --git a/webpack_config/server/webpack.base.js b/webpack_config/server/webpack.base.js
@@ -73,19 +73,6 @@ const baseWebpackConfig = {
 			//     }
 			//   ]
 			// }
-			{
-				test: /\.(jpe?g|png|gif|svg)$/,
-				use: [
-					{
-						loader: 'url-loader',
-						options: {
-							limit: 4096,
-							name: 'images/[name].[hash:6].[ext]'
-						}
-					},
-					'img-loader'
-				]
-			}
 		])
 	},
 	plugins: isomorphicWebpackConfig.plugins.concat([

diff --git a/webpack_config/webpack.isomorphic.js b/webpack_config/webpack.isomorphic.js
@@ -54,6 +54,19 @@ export default {
 				test: /\.(js|jsx)$/,
 				use: 'babel-loader',
 				exclude: [/node_modules/]
+			},
+			{
+				test: /\.(jpe?g|png|gif|svg)$/,
+				use: [
+					{
+						loader: 'url-loader',
+						options: {
+							limit: 4096,
+							name: 'images/[name].[hash:6].[ext]'
+						}
+					},
+					'img-loader'
+				]
 			}
 		]
 	},