From 7cea5912172627ae8503d9dc78bb9b5f1cafde31 Mon Sep 17 00:00:00 2001 From: Vladimir Metnev Date: Tue, 7 Nov 2017 02:46:53 +0200 Subject: [PATCH] fix(webpack_config): remove url-loader duplication in server and client configs fix(webpack_config): remove url-loader duplication in server and client configs --- webpack_config/client/webpack.base.js | 14 -------------- webpack_config/server/webpack.base.js | 13 ------------- webpack_config/webpack.isomorphic.js | 13 +++++++++++++ 3 files changed, 13 insertions(+), 27 deletions(-) diff --git a/webpack_config/client/webpack.base.js b/webpack_config/client/webpack.base.js index 67c1f7a2..a0f13d45 100644 --- a/webpack_config/client/webpack.base.js +++ b/webpack_config/client/webpack.base.js @@ -70,20 +70,6 @@ const baseBuild = { { test: /\.(ico|eot|otf|webp|ttf|woff|woff2)$/i, use: `file-loader?limit=100000&name=assets/[name].[hash:6].[ext]` - }, - { - test: /\.(jpe?g|png|gif|svg)$/, - use: [ - { - loader: 'url-loader', - options: { - limit: 4096, - // path: '/images', - name: 'images/[name].[hash:6].[ext]' - } - }, - 'img-loader' - ] } // NOTE: LQIP loader doesn't work with file-loader and url-loader :( // `npm i --save-dev lqip-loader` diff --git a/webpack_config/server/webpack.base.js b/webpack_config/server/webpack.base.js index 778acb60..dc6d3f49 100644 --- a/webpack_config/server/webpack.base.js +++ b/webpack_config/server/webpack.base.js @@ -73,19 +73,6 @@ const baseWebpackConfig = { // } // ] // } - { - test: /\.(jpe?g|png|gif|svg)$/, - use: [ - { - loader: 'url-loader', - options: { - limit: 4096, - name: 'images/[name].[hash:6].[ext]' - } - }, - 'img-loader' - ] - } ]) }, plugins: isomorphicWebpackConfig.plugins.concat([ diff --git a/webpack_config/webpack.isomorphic.js b/webpack_config/webpack.isomorphic.js index d8bca8ca..488290de 100644 --- a/webpack_config/webpack.isomorphic.js +++ b/webpack_config/webpack.isomorphic.js @@ -54,6 +54,19 @@ export default { test: /\.(js|jsx)$/, use: 'babel-loader', exclude: [/node_modules/] + }, + { + test: /\.(jpe?g|png|gif|svg)$/, + use: [ + { + loader: 'url-loader', + options: { + limit: 4096, + name: 'images/[name].[hash:6].[ext]' + } + }, + 'img-loader' + ] } ] },