Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade solidity-parser to remove antlr4 warnings with node 14 #1095

Closed
chatch opened this issue Dec 10, 2020 · 0 comments · Fixed by #1113
Closed

Upgrade solidity-parser to remove antlr4 warnings with node 14 #1095

chatch opened this issue Dec 10, 2020 · 0 comments · Fixed by #1113
Assignees
@fvictorio
Labels
type:chore A task related to code quality, tooling, CI, or anything that doesn't directly impact the end users

Comments

@chatch
Copy link

chatch commented Dec 10, 2020

Problem

Running the hardhat cli with Node 14 outputs the follow warnings:

(node:18497) Warning: Accessing non-existent property 'INVALID_ALT_NUMBER' of module exports inside circular dependency

More info from running hardhat cli with --trace-warnings:

(node:15755) Warning: Accessing non-existent property 'INVALID_ALT_NUMBER' of module exports inside circular dependency
    at emitCircularRequireWarning (internal/modules/cjs/loader.js:650:11)
    at Object.get (internal/modules/cjs/loader.js:664:5)
    at Object.<anonymous> (/home/hatch/projects/sb/startrail/app/node_modules/@solidity-parser/parser/dist/antlr4/RuleContext.js:32:46)

Antlr Fix

This is due to Antlr4 and was fixed here: antlr/antlr4#2834

It'ts fixed in

So an upgrade of the @solidity-parser will hopefully fix this.
@fvictorio fvictorio added the type:chore A task related to code quality, tooling, CI, or anything that doesn't directly impact the end users label Dec 11, 2020
@fvictorio fvictorio mentioned this issue Dec 17, 2020
Merged
@fvictorio fvictorio self-assigned this Nov 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fvictorio fvictorio

Labels
type:chore A task related to code quality, tooling, CI, or anything that doesn't directly impact the end users
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade solidity parser NomicFoundation/hardhat
2 participants
@fvictorio @chatch