Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the error type for hext to RGB(A) #350

Open
Ogeon opened this issue Aug 28, 2023 · 0 comments
Open

Refactor the error type for hext to RGB(A) #350

Ogeon opened this issue Aug 28, 2023 · 0 comments
Labels
definitely breaking Issues that are known before-hand to be a breaking change
Milestone
0.8.0

Comments

@Ogeon
Copy link
Owner

Ogeon commented Aug 28, 2023

Description

As mentioned in #347, the error type for FromStr can be improved a bit:

  • Remove the From<&'static str> implementation. It's ambiguous and not necessary for the library.
  • Remove the wrapped &str values. Each error has only one message anyway, or should have, so they can be part of the formatting instead.

Motivation

Focuses the purpose of the error type and removes ambiguity.
@Ogeon Ogeon added the definitely breaking Issues that are known before-hand to be a breaking change label Aug 28, 2023
@Ogeon Ogeon added this to the 0.7.7 milestone Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
definitely breaking Issues that are known before-hand to be a breaking change
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
1 participant
@Ogeon