Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.9 tests #924

Closed
rickecon opened this issue Apr 15, 2024 · 1 comment · Fixed by #925
Closed

Remove Python 3.9 tests #924

rickecon opened this issue Apr 15, 2024 · 1 comment · Fixed by #925

Comments

@rickecon
Copy link
Member

rickecon commented Apr 15, 2024

I propose that we follow a general rule across all the OG modeling repositories to run our build_and_test.py CI tests on all operating systems (OG-USA currently is not working on the Windows tests) and across only the two most recent versions of Python on which the code is being tested.

For example, for OG-Core, which is currently tested on Python 3.9, 3.10, and 3.11 but not on Python 3.12 yet (see Issue #889), we would change the build_and_test.py python matrix to just Python 3.10 and 3.11, dropping the 3.9 tests. And once we got the tests passing on Python 3.12, we would drop the Python 3.10 tests and only test on Python 3.11 and 3.12.

Let me know what you think about this approach.

cc: @jdebacker debacker

@jdebacker
Copy link
Member

jdebacker commented Apr 15, 2024

@rickecon I (@jdebacker) agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants