Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxonomic tree #32

Closed
diegozea opened this issue Mar 19, 2021 · 5 comments
Closed

Taxonomic tree #32

diegozea opened this issue Mar 19, 2021 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@diegozea
Copy link

Hi!

First, thank you very much for this package! It has been handy for me.

I think that it would be great to have an integration with Phylo.jl to easily get the common taxonomic tree for a set of taxa as in the NCBI site. That could be really useful for visualization and exploration.

Ideally, this can be a single function, similar to lineage and most probably depending on that, that also accepts stop_at, but that takes a list/set of NCBITaxons. For example:

using NCBITaxonomy

common_tree([ncbi"Bos taurus", ncbi"Mus musculus", ncbi"Homo sapiens"], stop_at=ncbi"Mammalia")

Best regards,

@diegozea diegozea added enhancement New feature or request need-triage labels Mar 19, 2021
@tpoisot
Copy link
Member

tpoisot commented Mar 19, 2021

Thank you! It's one of the planned features. I think @richardreeve has done the work on Phylo.jl to make it relatively easy to build, and that's definitely on my list.

@tpoisot tpoisot added documentation Improvements or additions to documentation and removed enhancement New feature or request need-triage labels Mar 23, 2021
@tpoisot
Copy link
Member

tpoisot commented Mar 23, 2021

I have made a documentation page with an example - I think it's a good idea, but I would like to think a bit about the best way to express it.

It can be something like

RootedTree(t::Vector{NCBITaxon}) # Or other types from Phylo

Or it can be a convert function. I'm unsure about the API. @richardreeve and @mkborregaard do you have preferences?

This will be a post v0.1.0 addition anyways, since I have modified the package a bit to make it faster.

@tpoisot
Copy link
Member

tpoisot commented Mar 23, 2021

@diegozea here is the use-case with Phylo.jl : http://docs.ecojulia.org/NCBITaxonomy.jl/dev/phylo/ -- I'm happy to keep thinking about how we can make the process efficient (and this will likely involve some performance improvements in lineage, which is not super fast now).

@diegozea
Copy link
Author

Thanks! That example is really useful :)

One thing; do you know why the tips are not being shown? I believe it is a problem with the plot recipe, as getleafnames(tree) works perfectly in that example.

@mkborregaard
Copy link

do you know why the tips are not being shown?

There seems to be a bug in the plot recipe. It must be due to changes in Plots, as this did work earlier. Could you open a Phylo issue for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants