Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing logmessage if signalduino_protocols.hash is missing #516

Closed
sidey79 opened this issue Feb 21, 2019 · 2 comments
Closed

Missing logmessage if signalduino_protocols.hash is missing #516

sidey79 opened this issue Feb 21, 2019 · 2 comments

Comments

@sidey79
Copy link
Contributor

sidey79 commented Feb 21, 2019

Expected Behavior

If the protocol hash could not be loaded, then a meaningfull log messages is needed.

There is already one in the code:
Error loading Protocol Hash. Module is in inoperable mode error message

Actual Behavior

There is not really a hint, that the hash could not be loaded:

2019.02.21 21:35:56.710 0: Featurelevel: 5.9
2019.02.21 21:35:56.712 0: Server started with 651 defined entities (fhem.pl:18623/2019-02-17 perl:5.024001 os:linux user:fhem pid:10904)
2019.02.21 21:35:57.235 3: sduino IdList: ### Attribute development is in this version ignored ###
2019.02.21 21:35:57.256 3: sduino: IDlist attr whitelist disabled or not defined (all IDs are enabled, except blacklisted and instable IDs):
2019.02.21 21:35:57.275 3: sduino: IDlist MS
2019.02.21 21:35:57.295 3: sduino: IDlist MU
2019.02.21 21:35:57.314 3: sduino: IDlist MC

Steps to Reproduce the Problem

  1. delete or rename signalduino_protocols.hash file
  2. restart fhem
  3. look at log messages that the signalduino_protocols.hash could not be loaded

Specifications

  • Versionmodul (FHEM Module): 3.3.3

signalduino_protocols

@sidey79
Copy link
Contributor Author

sidey79 commented Feb 21, 2019

GitMate.io thinks possibly related issues are #512 (Update signalduino_protocols.hash), #346 (Missing length_max check at in SIGNALduino_OSPIR), #347 (Missing length_max check at in SIGNALduino_MCTFA ), and #348 (Missing length_max check at in SIGNALduino_Maverick).

@sidey79 sidey79 added the fixed label Feb 25, 2019
@sidey79
Copy link
Contributor Author

sidey79 commented Feb 25, 2019

fixed via #522

@sidey79 sidey79 closed this as completed Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant