Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indenting with spaces instead of tabs #1

Closed
zurkoxxx opened this issue Aug 8, 2018 · 3 comments
Closed

Indenting with spaces instead of tabs #1

zurkoxxx opened this issue Aug 8, 2018 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@zurkoxxx
Copy link

zurkoxxx commented Aug 8, 2018

I have a problem.
Is there any way to make the extension use spaces instead of tabs for formatting?

P.S.
Really nice to see someone tackle this "formatting html inside php" issue.

@RiFi2k
Copy link
Owner

RiFi2k commented Aug 8, 2018

So you should just be able to set your html format options in code to use spaces instead of tabs, but I will take a closer look to make sure this is happening later today. If it doesn't work out the box right now I can quickly add this.
EDIT:
@zurkoxxx Just tried setting the code settings for HTML and you seem to be right. Good catch, I'll have this patched at some point later tonight.

@zurkoxxx
Copy link
Author

zurkoxxx commented Aug 9, 2018

@RiFi2k nice, thanks!

@RiFi2k
Copy link
Owner

RiFi2k commented Aug 11, 2018

Just want to let you know I didn't forget about you, @zurkoxxx

I decided to make some major improvements at the same time, so soon it will inherit every configuration possible for HTML formatting from a vscode setting.

  • indent-size
  • indent-char
  • indent-with-tabs
  • eol
  • end-with-newline
  • preserve-newlines
  • max-preserve-newlines
  • indent-inner-html
  • brace-style
  • indent-scripts
  • wrap-line-length
  • wrap-attributes
  • wrap-attributes-indent-size
  • inline
  • unformatted
  • content_unformatted
  • extra_liners

Also I should be able to grab any .editorconfig values and add those in automatically.

Also looking at formatting inline JS and CSS in PHP files according to the configurations you have set for those as well in code, but I don't know if that will make this release.

Check the 1.2.0 branch if you want to see the progress, it's real close just need to merge the options together better.

@RiFi2k RiFi2k self-assigned this Aug 11, 2018
@RiFi2k RiFi2k added the enhancement New feature or request label Aug 11, 2018
@RiFi2k RiFi2k closed this as completed in c46edb9 Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants