Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field Line coordinate autogeneration is inconsistent with SSL-Vision's generated coordinates #89

Open
rolfvdhulst opened this issue Jul 29, 2019 · 3 comments
Labels

Comments

@rolfvdhulst
Copy link

In SSLWorld.cpp the geometry is generated. The centre of each line is corrected by amount of LineThickness, however, in SSL-vision this does not happen. Not sure which one to take, but atleast both GrSim and SSL-vision should be consistent with each other.

@mahi97
Copy link
Member

mahi97 commented Jul 30, 2019

IMHO, You should try to be robust and more flexible to this configuration at this rate, we experienced robocups with wrong field size!

But you're right, we can at least have an standard about line and area of the field (maybe it's mentioned in rules implicitly).

Anyway, please feel free to send a pull request if ssl technical committee agreed on any of them.

@rolfvdhulst
Copy link
Author

The problem was the rules did not mention a standard implicitly on how the lines should be communicated through vision (e.g. take the 'outside' or the centre of the line), and this makes it easy to misinterpret. I notified the technical committee but still wanted to make this an issue so that users are aware.

@g3force
Copy link
Member

g3force commented Feb 10, 2021

There is an issue for this issue: RoboCup-SSL/ssl-rules#33

I've just created a patch for clarification in the rules. That would mean, we would adapt the behavior in grSim two that of ssl-vision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants