Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching for an invalid RegExp shows UNDEFINED #1721

Closed
matthias-brun opened this issue Dec 21, 2015 · 7 comments
Closed

Searching for an invalid RegExp shows UNDEFINED #1721

matthias-brun opened this issue Dec 21, 2015 · 7 comments
Assignees
Milestone

Comments

@matthias-brun
Copy link
Contributor

When searching for a string such as '(', which is an invalid regular expression the message 'Showing undefined results' is displayed.
screen shot 2015-12-21 at 17 45 15
I think there should be some error checking in order to display the 'Showing 0 results' message when an invalid regex is entered.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Joshua-Anderson
Copy link

I think that could be confusing because that would lead me to think that my regexp was valid but not finding anything. Maybe use a better error message like Invalid Regexp instead of Undefined?

An option to choose whether or not you want to search using a regexp would also be nice, because in this case it doesn't look like you intended ) to be treated as a regexp.

@matthias-brun
Copy link
Contributor Author

Good point actually. I didn't realize that searching with regexes was a thing until I got that error message. An option to choose whether or not to use a regex for searching would probably be the best solution indeed.
Edit: Or at least inform the user that his input is interpreted as a regex.

@alexbrazier
Copy link
Contributor

I think this has been resolved in #3850

@ggazzo
Copy link
Member

ggazzo commented Mar 8, 2017

@RocketChat/core the problem still persists on history/private but the link doesn't exist anymore.
What should I do? Fix the problem? delete the route?

@sampaiodiego
Copy link
Member

I think we don't need this page anymore.. that's why the link were removed.

@MartinSchoeler
Copy link
Contributor

@sampaiodiego so should this issue be closed?

@sampaiodiego
Copy link
Member

@MartinSchoeler no.. we have to decide to whether remove the page or fix it.

@Hudell Hudell self-assigned this Mar 12, 2018
@rodrigok rodrigok added this to the 0.63.0 milestone Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants