Disabling the "embed" feature does not take into full effect until a system restart

[sandrogauci]

Disabling the embed feature in /admin/API does not appear to disable automated HTTP requests upon parsing of URLs in the messages, even if automatic preview is disabled (i.e. you don't get to see the image or title of the page automatically). A restart does it. This I am told, could be improved.

Background:

sandrogauci 10:16 AM
I would like to disable automated HTTP requests from being done from rocket chat as soon as you paste a URL. I disabled the embed > feature from the [url]/admin/API and no previews are being done now but I can still notice that the app is doing an HTTP request
is there a limitation or did I miss something? (just installed rocket chat for the 1st time)
sandrogauci 1:38 PM
maybe @rodrigo.rocket.team or @gabriel.engel.rocket.team has a quick answer for me. I may look into addressing this if it is currently > a missing feature.
rodrigo.rocket.team 1:39 PM
@sandrogauci: we don't have that option
@rodrigo.rocket.team: ok.. do you think it should be separate from the "embed" option? i.e. if I were to change the code to not do > this HTTP request (when the option is set to not embed), what would be the implications?
by
@rodrigo.rocket.team: or I could rephrase that to - what is the reason (if any) that the HTTP request is being done even if embed is > off
rod 1:41 PM
has joined the channel.
rodrigo.rocket.team 1:42 PM
@sandrogauci: no, should be the oembed option, but we don't check that option when we get the file details, only when we render the > preview
can you open an issue to fix that?
sandrogauci 1:43 PM
okey then - I will open an issue .. thanks @rodrigo.rocket.team
rodrigo.rocket.team 1:43 PM
ur welcome
@sandrogauci: I was looking the code, we check that option, but you need to restart your application to take effect
can you try?
sandrogauci 1:44 PM
oh 😑
of course .. let me
rodrigo.rocket.team 1:45 PM
If I'm right, please open an issue to improve that 😃
sandrogauci 1:45 PM
testing in a minute
@rodrigo.rocket.team: positive .. you are indeed right. Will open an issue for that anyway as you ask.
rodrigo.rocket.team 1:47 PM
sure, thanks 😄
sandrogauci 1:47 PM
thank you!