Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RocketChat freezing (javascript aborting) on image preview #7224

Closed
soundstorm opened this issue Jun 12, 2017 · 4 comments
Closed

RocketChat freezing (javascript aborting) on image preview #7224

soundstorm opened this issue Jun 12, 2017 · 4 comments

Comments

@soundstorm
Copy link
Contributor

Rocket.Chat Version: 0.57.0.rc-1

When clicking an image title, the image will open without problems in a new tab. But the inline preview
yields TypeError: undefined is not an object (evaluating 't.replace') leading to no more execution of anything when clicked:

                                        o.importSync("photoswipe/dist/photoswipe-ui-default", {
                                            default: function(t) {
                                                i = t
                                            }
                                        }, 1), o.importSync("photoswipe/dist/photoswipe.css");
                                        var a = function(t) {
                                            return t.replace(/&/g, "&amp;").replace(/</g, "&lt;").replace(/>/g, "&gt;")
                                        };

photoswipe-js#L5

@soundstorm
Copy link
Contributor Author

Caused by #7121

@soundstorm
Copy link
Contributor Author

Happens (only?) with images from Slackbridge. As far as I can see:
Images uploaded with RC have "data-description" even if empty, that's missing for Slackbridge images (and descriptions are not synced at all).

@soundstorm
Copy link
Contributor Author

When viewing an image uploaded with RC - not sure depending on what, as I didn't upload the file - the same happens when the preview popup opens, so no SlackBridge-only bug.
Not reproducible to me at the moment what caused it with that specific image (tried to upload other image with same title and no description as the image was also downloaded the image and reuploaded it).

@soundstorm
Copy link
Contributor Author

soundstorm commented Jun 30, 2017

Fixed by #7187 / #7345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants