Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @brandFontName for brand icon's font-family CSS rule #59

Open
lolero opened this issue Feb 13, 2019 · 0 comments
Open

Use @brandFontName for brand icon's font-family CSS rule #59

lolero opened this issue Feb 13, 2019 · 0 comments

Comments

@lolero
Copy link

lolero commented Feb 13, 2019

Bug Report

The @brandFontName variable is not consumed in icon.overrides as it should be.

Steps

I have an open PR with the fix.

Expected Result

If I want to use different icon libraries aside from those offered by SUI, overriding the @brandFontName variable should render the icons that I want.

Actual Result

Overriding the @brandFontName variable does not render my third-party icons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lolero