Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when using Ensorcellation and Curio API together #41

Closed
Erfurt92 opened this issue Feb 25, 2020 · 3 comments
Closed

Bug when using Ensorcellation and Curio API together #41

Erfurt92 opened this issue Feb 25, 2020 · 3 comments
Assignees
Labels
type: bug Something isn't working

Comments

@Erfurt92
Copy link

Hey, I just want to let you know. There seems to be a bug with the Soulbound Enchant from Ensorcellation, when I'm using Curio API, if you have anything equipped in a Curio slots, doesn't matter if it's enchanted with Soulbound or not, all Soulbound items drops when you die, they also looses the enchant, although not all the time it would seem. I'm using the 1.15.2-2.0-beta2 versions of Curio, 1.15.2-0.3.0b version of Ensorcellation, and Forge 31.1.16. I have talked with KingLemmingCoFH about it, and he said "Yeah, that's 100% on their end.", although it seem to bug out their mod with some configs not going through, but what do I know.

@Erfurt92 Erfurt92 added the type: bug Something isn't working label Feb 25, 2020
@MrCrayfish
Copy link

I'm not the author of Curios but this is not TheIllusive's fault. Curios API isn't going to check for an enchantment from a random enchantment mod. All they can do is add a hook for developers to apply a predicate if an item should drop then it's up to KingLemmingCoFH to support it.

@TheIllusiveC4
Copy link
Owner

It's a priority issue. The problem is solvable on either end, but I have to assume they have a good reason for having it as they do so I just handled it on my side.

That said, the Soulbound enchantment randomly getting lost is reproducible with only Ensorcellation and CoFH Core installed so that issue is something you'll have to talk about with the developer.

@Erfurt92
Copy link
Author

I'm not the author of Curios but this is not TheIllusive's fault. Curios API isn't going to check for an enchantment from a random enchantment mod. All they can do is add a hook for developers to apply a predicate if an item should drop then it's up to KingLemmingCoFH to support it.

Don't get me wrong I assumed the same as you, that was why I reported it to KingLemmingCoFH first :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants