Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Crash since Neoforge 20.6.78-beta #414

Closed
cech12 opened this issue May 27, 2024 · 0 comments
Closed

[Bug]: Crash since Neoforge 20.6.78-beta #414

cech12 opened this issue May 27, 2024 · 0 comments
Assignees
Labels
status: confirmed This issue or pull request has been accepted type: bug Something isn't working

Comments

@cech12
Copy link

cech12 commented May 27, 2024

Minecraft Version

1.20.6

What happened?

When adding an item to a Curios slot, the game crashes.

The cause is, that Neoforge added a breaking change to their getResult and setResult methods in the events in version 20.6.78-beta.

Discord announcement:

NeoForge 20.6.78-beta introduces some changes around Event result handling.
This update removes the getResult and setResult methods in Event, and the associated magic @HasResult annotation. Events with a result now need to explicitly declare the getResult and setResult methods.
Additionally, the Event.Result enum is gone! We recommend that event authors either use the TriState class from NeoForge instead, or define a dedicated enum inside the event class.
NeoForge's own events have been updated accordingly. Every mod that calls .getResult or .setResult on an event will need changes.
(This only affects event results. Event cancellation is unchanged.)

How do you trigger this bug?

  1. start the game with at least one mod that adds a curios slot
  2. enter a world
  3. put an item into a Curios slot
  4. crash happens

Loader

NeoForge

Loader Version

20.6.78-beta

Mod Version

curios-neoforge-8.0.0-beta.3+1.20.6

Relevant Log Outputs

https://pastebin.com/yTXiMKjc

@cech12 cech12 added status: triage This issue or pull request is awaiting review type: bug Something isn't working labels May 27, 2024
@TheIllusiveC4 TheIllusiveC4 added status: confirmed This issue or pull request has been accepted and removed status: triage This issue or pull request is awaiting review labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: confirmed This issue or pull request has been accepted type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants