Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor generation of color variant components to use a curated set of accessible colors for all states #155

Open
cjg89 opened this issue Feb 7, 2019 · 0 comments
Labels
accessibility Related to an accessibility problem or potential improvement
Milestone

Comments

@cjg89
Copy link
Member

cjg89 commented Feb 7, 2019

Description

Currently in Athena, we maintain an extensive list of color variables, as well as accessible text color combinations for components using those colors; however, those color combinations only pertain to default component states. We don't currently have a curated set of hover/focus/active state colors; those state colors tend to get generated/modified in mixins based on the default states' colors, meaning we have less control over what color combinations get generated for those states.

Some of our button variant states don't currently meet contrast requirements (e.g. the success/info/warning/danger outline buttons). Additionally, navbars don't use a color variant system at all; nav link colors are determined by a .navbar-light or .navbar-inverse class and whatever background utility class is added to the navbar.

We should create a list of designated color combinations for these alternate states, and refactor how these components get generated to ensure these color combinations are always used. This will likely mean a deprecation of the .navbar-light/.navbar-inverse classes for navbars, and shifting navbars to a color variant model (like buttons, badges, and cards).

Why it's Important

Unless manually overridden in Athena, most (interactive) components' hover/active states don't take into account color contrast requirements for accessibility.

Alternatives

n/a

Possible Implementation

See above

Additional context

n/a

@cjg89 cjg89 added the accessibility Related to an accessibility problem or potential improvement label Feb 7, 2019
@cjg89 cjg89 added this to the backlog milestone Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Related to an accessibility problem or potential improvement
Projects
None yet
Development

No branches or pull requests

1 participant