Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global rules are not handled properly on master #2022

Closed
vthib opened this issue Dec 10, 2023 · 0 comments
Closed

Global rules are not handled properly on master #2022

vthib opened this issue Dec 10, 2023 · 0 comments
Labels

Comments

@vthib
Copy link
Contributor

vthib commented Dec 10, 2023

Global rules with string matches do not seem to behave properly anymore, and even if they do not match, normal rules that match are returned.

Steps to reproduce the behavior:

with this file:

global rule g1 {
    strings:
        $ = "g1"
    condition: all of them
}

rule foo {
    strings:
        $ = "foo"
    condition: all of them
}

and an input foo, the foo rule is reported as matching, but should not, since the global rule did not match.

yara 4.3.1 does not have the bug, not does yara 4.4.0, but master has it.

Bisecting seems to indicate this commit introduced the regression: b26b000

@vthib vthib added the bug label Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant