Skip to content
This repository has been archived by the owner on Jan 23, 2018. It is now read-only.

File Structure #8

Closed
Hossman333 opened this issue Mar 13, 2017 · 8 comments
Closed

File Structure #8

Hossman333 opened this issue Mar 13, 2017 · 8 comments
Assignees

Comments

@Hossman333
Copy link

Seems a lil chaotic.

@Xaeroxe
Copy link
Owner

Xaeroxe commented Mar 13, 2017

I typically prefer to "write it down now and organize later". I like this because the ideal organization won't be apparent until more code is present. So I'll keep this issue open and close it after I've organized and refactored.

@Xaeroxe
Copy link
Owner

Xaeroxe commented Mar 14, 2017

Some musings on good ways to accomplish this: gnu-mingw and msvc are folders that contain libs and dlls but that's not apparent until you open them, we can make that more obvious at a surface level by switching the folder hierarchy to be more like this:
lib/gnu-mingw/32
dll/gnu-mingw/32

instead of its current form. Edit: this has been completed.

Audio is also scattered throughout app.rs, so moving that into it's own structure that will become part of App would be a good idea, it would especially help with keeping relevant functionality in one place. Edit: this has been completed.

pub(restricted) would help with organization a lot, as it would remove the need for these _private modules. That feature is ready to be stabilized in https://github.com/rust-lang/rust they're just waiting for someone to do it, so I think I'll submit a PR to stabilize that feature, then once it is released we can clean up this filesystem. Edit: As I was just getting ready to start creating the PR I discovered @cramertj had already made the PR and it was well on its way into the repo. Thanks cramer!

mod.rs files should be reserved for declaring other modules, this is not how I've been using them thus far though. Edit: This has been completed.

@Xaeroxe
Copy link
Owner

Xaeroxe commented Mar 18, 2017

rust-lang/rust#40556 pub(restricted) stabilization PR. As soon as this is merged and released to stable I can clean up the accession chains.

@Xaeroxe
Copy link
Owner

Xaeroxe commented Mar 18, 2017

01c60bf and e260189 helped with this quite a bit. Once pub(restricted) lands and that's integrated into nitro I'll close this issue.

@Xaeroxe Xaeroxe self-assigned this Mar 18, 2017
@Xaeroxe
Copy link
Owner

Xaeroxe commented Mar 18, 2017

7b89ace yet another rearrangment commit.

@Xaeroxe
Copy link
Owner

Xaeroxe commented Mar 21, 2017

Woo pub(restricted) stabilization PR has been merged! Now we just have to wait for Rust 1.18

@Xaeroxe
Copy link
Owner

Xaeroxe commented Jun 9, 2017

Rust 1.18 has been released, and the code has been updated to use it. Closing this issue now.

@Xaeroxe Xaeroxe closed this as completed Jun 9, 2017
@Hossman333
Copy link
Author

Boom! 🎉 💥

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants