Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: reduce the vertical spacing of fonts in menu and item spacers #794

Closed
xandark opened this issue Apr 21, 2024 · 2 comments
Closed
Labels
feature request User-facing feature additions/enhancements MGTK MouseGraphics ToolKit library
Milestone

Comments

@xandark
Copy link

xandark commented Apr 21, 2024

Would it be possible to make the spacing of the menu items and menu item dividers have less vertical whitespace?

I'm comparing a2d to Catalyst:

a2d menu

Catalyst menu

It seems more readable to my eyes in the Catalyst version in the menu. The items are not so spread out.

Also, I imagine if there were less drawn whitespace, it would draw/erase faster.

@xandark xandark added DeskTop DeskTop bugs or feature requests feature request User-facing feature additions/enhancements labels Apr 21, 2024
@inexorabletash
Copy link
Collaborator

Current:
image

It's possible to squeeze one pixel out of each menu item height. This reduces the space before each item, and ends up with the highlighting looking bottom-heavy, due to descenders:
image

Tweaking the highlight rect a bit gives this, which I think is acceptable:
image

Based on the way MGTK calculates and draws menus, making the spacers smaller than regular items would be significant work, so that's not gonna happen.

@inexorabletash inexorabletash added MGTK MouseGraphics ToolKit library and removed DeskTop DeskTop bugs or feature requests labels Apr 22, 2024
@inexorabletash inexorabletash added this to the 1.4 milestone Apr 23, 2024
@xandark
Copy link
Author

xandark commented Apr 24, 2024

I like the new tighter look of the menu items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request User-facing feature additions/enhancements MGTK MouseGraphics ToolKit library
Projects
None yet
Development

No branches or pull requests

2 participants