Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[makeotfexe] hotconv featgram.c Xcode compiler: many errors from unnecessary parens in featgram.c #83

Closed
readroberts opened this issue Nov 6, 2015 · 0 comments · Fixed by #1367

Comments

@readroberts
Copy link
Contributor

The -Wparentheses-equality warning is useful for more than just extra parens, and I'd like to keep it. Solved the problem by fixing the source code in featgram.c. A short -term solution: I replaced all occurrences of "(if|while) (\s+(LA(1)==([^)]+))\s*)" with " \1 (LA(1)==\2)". Short-term because this will have to be repeated every time someone regenerates the featgram.c file by running the ANTLR parser. Needs to eventually be fixed in the ANTLR parser itself.

@miguelsousa miguelsousa changed the title hotconv featgram.c Xcode compiler: many errors from unnecessary parens in featgram.c [makeotfexe] hotconv featgram.c Xcode compiler: many errors from unnecessary parens in featgram.c Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants