Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[project panel] Selection arrow touches line numbers > 999 #3517

Closed
redmunds opened this issue Apr 20, 2013 · 5 comments
Closed

[project panel] Selection arrow touches line numbers > 999 #3517

redmunds opened this issue Apr 20, 2013 · 5 comments
Assignees
Milestone

Comments

@redmunds
Copy link
Contributor

If you open a file with more than 1000 lines such as Editor.js and go down to the bottom, the selection arrow from the Project panel touches the line numbers. Seems like there should be a little more margin.

@ghost ghost assigned jasonsanjose Apr 20, 2013
@peterflynn
Copy link
Member

Seems like a tough tradeoff... having a wider margin would use up space for something not super frequent. But there's also the larger issue that the gutter will eventually need to contain markers -- breakpoints, for example. We'd have to widen the gutter even further to make that work. I wonder if there are other options... making the arrow translucent maybe, or layering it underneath those other decorations, or having it clip/fade out when near them?

@redmunds
Copy link
Contributor Author

Definitely not an easy solution. For Sprint 24, I'd like to see just enough pixels added so the arrow doesn't touch the digits.

@jasonsanjose
Copy link
Member

Reviewed

@jasonsanjose
Copy link
Member

Not too much of a tradeoff actually. We have min-width of 2.5em. I added 10px padding-left so that we never overlap with the triangle. CodeMirror takes care of the rest as the number of digits grow.

@RaymondLim
Copy link
Contributor

Fix confirmed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants