Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Go to Line shows Quick Open-style file matches if they contain ":" #6646

Closed
peterflynn opened this issue Jan 26, 2014 · 5 comments
Closed

Go to Line shows Quick Open-style file matches if they contain ":" #6646

peterflynn opened this issue Jan 26, 2014 · 5 comments

Comments

@peterflynn
Copy link
Member

  1. On Windows, open a file external to the project
  2. Invoke 'Go to Line'

Result: the external file is listed in a dropdown like a regular Quick Open result, even though the leading ":" means we're in "Go to Line" mode. If the path/filename contains numbers, it can continue to show as you type a line number too.

I assume this will also repro if you're on Mac with a filename that contains ":" (I think that is a legal filename char on Mac/Linux).

Repros in Sprint 35 but not Sprint 33, so this is a semi-recent regression.

@ghost ghost assigned JeffryBooher Jan 28, 2014
@JeffryBooher
Copy link
Contributor

Open to myself

@JeffryBooher
Copy link
Contributor

Fix In Progress @peterflynn

@peterflynn
Copy link
Member Author

Reviewed. We think this will land in 1.0 but it's not important if it doesn't, so removing milestone

@marcelgerber
Copy link
Contributor

@peterflynn Looks like you missed closing this issue :)

@peterflynn
Copy link
Member Author

Yep, confirmed this is fixed now too -- thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants