Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexer v. algod nightly test is likely broken #1495

Closed
tzaffi opened this issue Mar 5, 2023 · 3 comments
Closed

indexer v. algod nightly test is likely broken #1495

tzaffi opened this issue Mar 5, 2023 · 3 comments
Labels
new-bug Bug report that needs triage

Comments

@tzaffi
Copy link
Contributor

tzaffi commented Mar 5, 2023

Broken Nightly Test - Re-imagine or Just Remove

We can see that the nightly indexer v. algod test is failing. This is because the go-algorand submodule dependency has been removed (though the error on Circle seems to obscure this).

I don't know if the test even makes sense anymore, but before removing, we ought to assess whether it is worth to keep some version of it.

@tzaffi tzaffi added the new-bug Bug report that needs triage label Mar 5, 2023
@tzaffi
Copy link
Contributor Author

tzaffi commented Mar 6, 2023

@shiqizng and @winder have noted that this is not obsolete, so the job needs to be amended / rethought

@tzaffi tzaffi changed the title indexer v. algod nightly test is likely obsolete indexer v. algod nightly test is likely broken ~obsolete~ Mar 6, 2023
@tzaffi tzaffi changed the title indexer v. algod nightly test is likely broken ~obsolete~ indexer v. algod nightly test is likely broken Mar 6, 2023
@winder
Copy link
Contributor

winder commented Mar 6, 2023

This is hopefully addressed by #1496 (review)

@tzaffi
Copy link
Contributor Author

tzaffi commented Mar 6, 2023

Ok, so the error I was seeing is the real error.

@tzaffi tzaffi closed this as completed Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-bug Bug report that needs triage
Projects
None yet
Development

No branches or pull requests

2 participants