Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Invert alias and struct declaration for BlockNumHash #1266

Closed
mattsse opened this issue Sep 9, 2024 · 2 comments
Closed

[Feature] Invert alias and struct declaration for BlockNumHash #1266

mattsse opened this issue Sep 9, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@mattsse
Copy link
Member

mattsse commented Sep 9, 2024

Component

consensus, eips, genesis

Describe the feature you would like

same as #1264 but for BlockNumHash ref #1265

note: only swap the struct name and alias

Additional context

No response
@mattsse mattsse added the enhancement New feature or request label Sep 9, 2024
@PanGan21
Copy link
Contributor

PanGan21 commented Sep 10, 2024 •
edited
Loading

Hi @mattsse could it be that you mean BlockHashOrNumber in the ticket instead of BlockNumHash?
If that is the case I opened a pr for it in #1270

@PanGan21 PanGan21 mentioned this issue Sep 10, 2024
Merged
3 tasks
@mattsse
Copy link
Member Author

mattsse commented Sep 11, 2024

closed by #1270

@mattsse mattsse closed this as completed Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattsse @PanGan21