Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relevant css lint to generated project #13502

Closed
kmturley opened this issue Jan 22, 2019 · 4 comments
Closed

Add relevant css lint to generated project #13502

kmturley opened this issue Jan 22, 2019 · 4 comments

Comments

@kmturley
Copy link

🚀 Feature request

Command (mark with an x)

- [x] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Description

When running the command ng new example-project the user is prompted to select a css framework type. This is added to your project and you can quickly start development. However it does not add any quality standards/tests for css, scss, sass, less. This means either a project doesn't have consistent css standards or they have to be manually added later.

Describe the solution you'd like

Automatically add the relevant css linting tool to the package.json

And of course add the relevant command to package.json e.g.

  "scripts": {
    "ng": "ng",
    "start": "ng serve",
    "build": "ng build",
    "test": "ng test",
    "lint": "ng lint && sass-lint",
    "e2e": "ng e2e"
  },

Describe alternatives you've considered

Manually installing the library for every new project, or ensuring every developer has it installed in their Code Editor.

@mgechev mgechev added the needs: discussion On the agenda for team meeting to determine next steps label Jan 23, 2019
@mgechev
Copy link
Member

mgechev commented Jan 24, 2019

@kmturley soon we're going to release new architect API which will let supporting CSS/Sass/Less linting through external plugins.

Although we'd prefer to keep this outside of the CLI, I'd love to collaborate on creating external builders which folks can add to their projects.

Here's the new API, you can also find sample builders there. Once we merge the PR, feel free to look at how you can create custom builders. If you hit any issues, feel free to reach out to me over email.

@mgechev mgechev closed this as completed Jan 24, 2019
@kmturley
Copy link
Author

sounds good, I think it's smart to allow anyone to make a modifier to angular cli projects. To append, change packages etc.

I wonder whether we can encourage package owners to create them, so that their packages are more easily added to Angular projects?

The reason being that if the base package changes, the modifier will likely need to be updated, so ideally by the same maintainer

@mgechev
Copy link
Member

mgechev commented Jan 24, 2019

Yes, it'll be great if package maintainers have the bandwidth to provide CLI builders. This will definitely grow the popularity of their projects.

@alan-agius4 alan-agius4 removed the needs: discussion On the agenda for team meeting to determine next steps label Mar 18, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants