Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ runtime shared library build needs ANTLR4CPP_EXPORTS to be defined but is not #1547

Closed
adrpo opened this issue Dec 23, 2016 · 3 comments
Closed

Comments

@adrpo
Copy link
Contributor

adrpo commented Dec 23, 2016

You can in general do:
cmake -DCMAKE_CXX_FLAGS:STRING=-DANTLR4CPP_EXPORTS
to fix this but maybe one should assume that by default this should be defined if you build the shared library. If you don't define it then the assumption is (at least on Windows:
#define ANTLR4CPP_PUBLIC __declspec(dllimport)
which generates errors if you try to compile the C++ files with MinGW g++.

@adrpo
Copy link
Contributor Author

adrpo commented Dec 24, 2016

Should be fixed by PR: #1548

@adrpo
Copy link
Contributor Author

adrpo commented Dec 24, 2016

also make install will fail because it wants to install License.txt which does not exist :)
https://github.com/antlr/antlr4/blob/master/runtime/Cpp/CMakeLists.txt#L110

@adrpo
Copy link
Contributor Author

adrpo commented Dec 25, 2016

Fixed by PR: #1548.

@adrpo adrpo closed this as completed Dec 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant